Re: [PATCH net-next 1/3] dsa: add support for Arrow XRS700x tag trailer

On Mon, Nov 23, 2020 at 4:18 PM Florian Fainelli [off-list ref] wrote:

On 11/20/2020 10:16 AM, George McCollister wrote:

quoted

Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
is modeled on tag_trailer.c which works in a similar way.

Signed-off-by: George McCollister <george.mccollister@gmail.com>

One question below:

[snip]

quoted

+     if (pskb_trim_rcsum(skb, skb->len - 1))
+             return NULL;
+
+     /* Frame is forwarded by hardware, don't forward in software. */
+     skb->offload_fwd_mark = 1;

Given the switch does not give you a forwarding reason, I suppose this
is fine, but do you possibly have to qualify this against different
source MAC addresses?

I don't see any reason why I'd need to do that but maybe I'm missing something.

--
Florian