On Tue, Nov 3, 2020 at 10:34 AM Andrii Nakryiko
[off-list ref] wrote:

On Sat, Oct 31, 2020 at 11:52 AM Alexander Duyck
[off-list ref] wrote:

quoted

From: Alexander Duyck <alexanderduyck@fb.com>

Recently a bug was missed due to the fact that test_tcpbpf_user is not a
part of test_progs. In order to prevent similar issues in the future move
the test functionality into test_progs. By doing this we can make certain
that it is a part of standard testing and will not be overlooked.

As a part of moving the functionality into test_progs it is necessary to
integrate with the test_progs framework and to drop any redundant code.
This patch:
1. Cleans up the include headers
2. Dropped a duplicate definition of bpf_find_map
3. Switched over to using test_progs specific cgroup functions
4. Replaced printf calls with fprintf to stderr

This is not necessary. test_progs intercept both stdout and stderr, so
you could have kept the code as is and minimize this diff further. But
it also doesn't matter all that much, so:

Yeah. I can probably just drop those changes if that is preferred. As
is all the printf/fprintf calls are eliminated by the end anyway.

Acked-by: Andrii Nakryiko <andrii@kernel.org>

Thanks for the review.

- Alex