Thread (3 messages) 3 messages, 2 authors, 2020-11-30

Re: [PATCH] NFC: nxp-nci: Make firmware GPIO pin optional

From: Frieder Schrempf <hidden>
Date: 2020-11-30 11:50:27
Also in: linux-devicetree, lkml

On 30.11.20 12:44, Andy Shevchenko wrote:
On Mon, Nov 30, 2020 at 1:06 PM Schrempf Frieder
[off-list ref] wrote:
quoted
From: Frieder Schrempf <redacted>

There are other NXP NCI compatible NFC controllers such as the PN7150
that use an integrated firmware and therefore do not have a GPIO to
select firmware downloading mode. To support these kind of chips,
let's make the firmware GPIO optional.
...
quoted
-       gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);
+       if (phy->gpiod_fw)
+               gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);
This change is not needed.
Indeed, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help