Thread (3 messages) flat view 3 messages, 2 authors, 2020-11-29

Re: [PATCH] bpf: remove trailing semicolon in macro definition

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2020-11-28 00:57:01
Also in: bpf, lkml

On 11/27/20 8:27 PM, trix@redhat.com wrote:
quoted hunk ↗ jump to hunk
From: Tom Rix <trix@redhat.com>

The macro use will already have a semicolon.

Signed-off-by: Tom Rix <trix@redhat.com>
---
  include/trace/events/xdp.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
index cd24e8a59529..65ffedf8386f 100644
--- a/include/trace/events/xdp.h
+++ b/include/trace/events/xdp.h
@@ -146,13 +146,13 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err,
  );
  
  #define _trace_xdp_redirect(dev, xdp, to)		\
-	 trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to);
+	 trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to)
  
  #define _trace_xdp_redirect_err(dev, xdp, to, err)	\
  	 trace_xdp_redirect_err(dev, xdp, NULL, err, NULL, to);
  
  #define _trace_xdp_redirect_map(dev, xdp, to, map, index)		\
-	 trace_xdp_redirect(dev, xdp, to, 0, map, index);
+	 trace_xdp_redirect(dev, xdp, to, 0, map, index)
  
  #define _trace_xdp_redirect_map_err(dev, xdp, to, map, index, err)	\
  	 trace_xdp_redirect_err(dev, xdp, to, err, map, index);
This looks random, why those but not other locations ?

Thanks,
Daniel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help