Re: [PATCH bpf v2 1/2] xsk: replace datagram_poll by sock_poll_wait
From: Magnus Karlsson <hidden>
Date: 2020-11-27 08:23:26
Also in:
bpf, lkml
On Wed, Nov 25, 2020 at 7:49 AM Xuan Zhuo [off-list ref] wrote:
datagram_poll will judge the current socket status (EPOLLIN, EPOLLOUT) based on the traditional socket information (eg: sk_wmem_alloc), but this does not apply to xsk. So this patch uses sock_poll_wait instead of datagram_poll, and the mask is calculated by xsk_poll. Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com> --- net/xdp/xsk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
quoted hunk ↗ jump to hunk
diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c index b014197..0df8651 100644 --- a/net/xdp/xsk.c +++ b/net/xdp/xsk.c@@ -534,11 +534,13 @@ static int xsk_sendmsg(struct socket *sock, struct msghdr *m, size_t total_len) static __poll_t xsk_poll(struct file *file, struct socket *sock, struct poll_table_struct *wait) { - __poll_t mask = datagram_poll(file, sock, wait); + __poll_t mask = 0; struct sock *sk = sock->sk; struct xdp_sock *xs = xdp_sk(sk); struct xsk_buff_pool *pool; + sock_poll_wait(file, sock, wait); + if (unlikely(!xsk_is_bound(xs))) return mask; --1.8.3.1