Thread (11 messages) 11 messages, 3 authors, 2020-11-27

Re: [PATCH bpf-next v3 1/6] net: Remove the err argument from sock_from_file

From: KP Singh <hidden>
Date: 2020-11-26 22:58:20
Also in: bpf, lkml

On Thu, Nov 26, 2020 at 5:45 PM Florent Revest [off-list ref] wrote:
Currently, the sock_from_file prototype takes an "err" pointer that is
either not set or set to -ENOTSOCK IFF the returned socket is NULL. This
makes the error redundant and it is ignored by a few callers.

This patch simplifies the API by letting callers deduce the error based
on whether the returned socket is NULL or not.

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Florent Revest <redacted>
Reviewed-by: KP Singh <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help