Thread (4 messages) flat view 4 messages, 3 authors, 2020-11-18

Re: [PATCH net] atl1e: fix error return code in atl1e_probe()

From: Zhang Changzhong <hidden>
Date: 2020-11-18 03:25:53
Also in: lkml


On 2020/11/18 4:38, Marion & Christophe JAILLET wrote:
Le 17/11/2020 à 03:57, Zhang Changzhong a écrit :
quoted
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API")
Hi, should it have any importance, the Fixes tag is wrong.

The issue was already there before 85eb5bc33717 which was just a mechanical update.

just my 2c

CJ
Thanks for reminding, the correct Fixes tag should be:

Fixes: a6a5325239c2 ("atl1e: Atheros L1E Gigabit Ethernet driver"
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help