Thread (18 messages) flat view 18 messages, 5 authors, 2020-11-14

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-11-11 16:00:37
Also in: lkml

On Wed, 11 Nov 2020 05:55:58 -0800 Richard Cochran wrote:
On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote:
quoted
Following Richard's comments v1 of the patch has to be applied [1].
I've also added my Reviewed-by there.

[1] https://lore.kernel.org/patchwork/patch/1334067/  
+1

Jakub, can you please take the original v1 of this patch?
I don't think v1 builds cleanly folks (not 100% sure, cpts is not
compiled on x86):

		ret = cpts->ptp_clock ? cpts->ptp_clock : (-ENODEV);

ptp_clock is a pointer, ret is an integer, right?

Grygorii, would you mind sending a correct patch in so Wang Qing can
see how it's done? I've been asking for a fixes tag multiple times
already :(
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help