Re: [PATCH V2 net-next 05/11] net: hns3: add support for dynamic interrupt moderation

On 2020/11/11 9:20, Jakub Kicinski wrote:

On Mon, 9 Nov 2020 11:22:33 +0800 Huazhong Tan wrote:

quoted

Add dynamic interrupt moderation support for the HNS3 driver.

Signed-off-by: Huazhong Tan <redacted>

I'm slightly confused here. What does the adaptive moderation do in
your driver/device if you still need DIM on top of it?

The driver's adaptive moderation and DIM are mutually-exclusive options,
and DIM is used by default. Since it is hard to verify all cases that
DIM can get a better result, so keep the adaptive moderation as an
option now, which can be swicthed by the ethtool priv-flag. If DIM is ok
for a long time, then we will send a separate patch to  remove the
adaptive moderation from the driver.

Thanks.