Re: [Linux-kernel-mentees] [PATCH v3 net] rose: Fix Null pointer dereference in rose_send_frame()
From: Anmol Karn <hidden>
Date: 2020-11-10 19:45:30
Also in:
linux-hams, linux-kernel-mentees, lkml
From: Anmol Karn <hidden>
Date: 2020-11-10 19:45:30
Also in:
linux-hams, linux-kernel-mentees, lkml
Hello Sir, On Tue, Nov 10, 2020 at 09:58:15AM -0800, Jakub Kicinski wrote:
On Sun, 8 Nov 2020 00:48:35 +0530 Anmol Karn wrote:quoted
+ dev = rose_dev_get(dest);this calls dev_hold internally, you never release that reference in case ..neigh->dev is NULLquoted
+ if (rose_loopback_neigh->dev && dev) {
Ah, I missed to `dev_put()` the `dev` after checking for, if neigh->dev is NULL, I will fix it soon and send another version. Thank you for review. Anmol