Thread (3 messages) flat view 3 messages, 3 authors, 2020-11-10

Re: [PATCH v2 net-next] net: skb_vlan_untag(): don't reset transport offset if set by GRO layer

From: patchwork-bot+netdevbpf@kernel.org
Date: 2020-11-10 04:20:08
Also in: lkml

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 09 Nov 2020 23:47:23 +0000 you wrote:
Similar to commit fda55eca5a33f
("net: introduce skb_transport_header_was_set()"), avoid resetting
transport offsets that were already set by GRO layer. This not only
mirrors the behavior of __netif_receive_skb_core(), but also makes
sense when it comes to UDP GSO fraglists forwarding: transport offset
of such skbs is set only once by GRO receive callback and remains
untouched and correct up to the xmitting driver in 1:1 case, but
becomes junk after untagging in ingress VLAN case and breaks UDP
GSO offload. This does not happen after this change, and all types
of forwarding of UDP GSO fraglists work as expected.

[...]
Here is the summary with links:
  - [v2,net-next] net: skb_vlan_untag(): don't reset transport offset if set by GRO layer
    https://git.kernel.org/netdev/net-next/c/8be33ecfc1ff

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help