Thread (4 messages) 4 messages, 3 authors, 2020-11-10

Re: Subject: [RFC] clang tooling cleanups

From: Joe Perches <joe@perches.com>
Date: 2020-11-10 02:52:23
Also in: alsa-devel, amd-gfx, cocci, dri-devel, linux-amlogic, linux-aspeed, linux-btrfs, linux-crypto, linux-iio, linux-mediatek, linux-mmc, linux-nfs, linux-pm, linux-rdma, linux-rtc, linux-samsung-soc, linux-scsi, linux-tegra, lkml

On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote:
This rfc will describe
An upcoming treewide cleanup.
How clang tooling was used to programatically do the clean up.
Solicit opinions on how to generally use clang tooling.

The clang warning -Wextra-semi-stmt produces about 10k warnings.
Reviewing these, a subset of semicolon after a switch looks safe to
fix all the time.  An example problem

void foo(int a) {
     switch(a) {
     	       case 1:
	       ...
     }; <--- extra semicolon
}

Treewide, there are about 100 problems in 50 files for x86_64 allyesconfig.
These fixes will be the upcoming cleanup.
coccinelle already does some of these.

For instance: scripts/coccinelle/misc/semicolon.cocci

Perhaps some tool coordination can be done here as
coccinelle/checkpatch/clang/Lindent call all be used
to do some facet or another of these cleanup issues.


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help