Thread (35 messages) 35 messages, 6 authors, 2020-11-04

Re: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header

From: Lee Jones <hidden>
Date: 2020-11-04 14:28:41
Also in: linux-arm-kernel, lkml

On Wed, 04 Nov 2020, Andrew Lunn wrote:
On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote:
quoted
Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set'
 drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Ivan Khoronzhuk <redacted>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

I _think_ these have got missed so far in the various cleanup passes
because of missing COMPILE_TEST. I've been adding that as part of
fixing these warnings. When your respin, could you add that as well?
Yes, no problem.

Just for this symbol?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help