Re: [PATCH net-next 2/4] net: dsa: Link aggregation support
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-11-28 22:19:05
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-11-28 22:19:05
quoted
OK I think I finally see what you are saying. Sorry it took me this long. I do not mean to be difficult, I just want to understand.
Not a problem. This is a bit different to normal, the complexity of the stack means you need to handle this different to most drivers. If you have done any deeply embedded stuff, RTOS, allocating everything up front is normal, it eliminates a whole class of problems.
quoted
How about this: - Add a `lags_max` field to `struct dsa_switch` to let each driver define the maximum number supported by the hardware.
This is all reasonable. I just wonder what that number is for the
mv88e6xx case, especially for D in DSA. I guess LAGs are global in
scope across a set of switches. So it does not matter if there is one
switch or lots of switches, the lags_max stays the same.
Andrew