Re: [PATCHv2 net] sctp: change to hold/put transport for proto_unreach_timer

On Sat, 14 Nov 2020 10:40:23 -0300 Marcelo Ricardo Leitner wrote:

On Sat, Nov 14, 2020 at 01:22:53PM +0800, Xin Long wrote:

quoted

A call trace was found in Hangbin's Codenomicon testing with debug kernel:
  

...

quoted

So fix it by holding/putting transport instead for proto_unreach_timer
in transport, just like other timers in transport.

v1->v2:
  - Also use sctp_transport_put() for the "out_unlock:" path in
    sctp_generate_proto_unreach_event(), as Marcelo noticed.

Fixes: 50b5d6ad6382 ("sctp: Fix a race between ICMP protocol unreachable and connect()")
Reported-by: Hangbin Liu <redacted>
Signed-off-by: Xin Long <lucien.xin@gmail.com>  

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

Applied, thanks!