On November 2, 2020 6:46:12 PM Kalle Valo [off-list ref] wrote:

Arend Van Spriel [off-list ref] writes:

quoted

On November 2, 2020 6:15:32 PM Kalle Valo [off-list ref] wrote:

quoted

Seung-Woo Kim [off-list ref] writes:

quoted

There are missig brcmf_free() for brcmf_alloc(). Fix memory leak
by adding missed brcmf_free().

Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
Fixes: commit 450914c39f88 ("brcmfmac: split brcmf_attach() and
brcmf_detach() functions")

This should be:

Fixes: 450914c39f88 ("brcmfmac: split brcmf_attach() and
brcmf_detach() functions")

But I can fix that, no need to resend because of this.

Hi Kalle,

But this is not the commit that needs fixing as I mentioned before.
Instead it should be a1f5aac1765af ("brcmfmac: don't realloc wiphy
during PCIe reset") which introduced the actual memory leak.

I'll then change it to:

Fixes: a1f5aac1765a ("brcmfmac: don't realloc wiphy during PCIe reset")

Is that ok?

It is for me ;-)

Regards,
Arend