net: usbnet: remove driver version

Started by Heiner Kallweit on Oct 9, 2020 · 3 messages from 3 authors · Last reply Oct 10, 2020

Subsystems (4)

Show 1 more

Maintainers (7)

Show 3 more
STALE2211d

open the first message on its own page

  1. [PATCH net-next] net: usbnet: remove driver version
    Related patches

[PATCH net-next] net: usbnet: remove driver version

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2020-10-09 12:11:12

Obviously this driver version doesn't make sense. Go with the default
and let ethtool display the kernel version.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/usb/usbnet.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index bf6c58240..963d260d1 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -34,9 +34,6 @@
 #include <linux/kernel.h>
 #include <linux/pm_runtime.h>
 
-#define DRIVER_VERSION		"22-Aug-2005"
-
-
 /*-------------------------------------------------------------------------*/
 
 /*
@@ -1047,7 +1044,6 @@ void usbnet_get_drvinfo (struct net_device *net, struct ethtool_drvinfo *info)
 	struct usbnet *dev = netdev_priv(net);
 
 	strlcpy (info->driver, dev->driver_name, sizeof info->driver);
-	strlcpy (info->version, DRIVER_VERSION, sizeof info->version);
 	strlcpy (info->fw_version, dev->driver_info->description,
 		sizeof info->fw_version);
 	usb_make_path (dev->udev, info->bus_info, sizeof info->bus_info);
-- 
2.28.0

Re: [PATCH net-next] net: usbnet: remove driver version

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2020-10-09 13:07:25

On Fri, Oct 09, 2020 at 02:10:57PM +0200, Heiner Kallweit wrote:
Obviously this driver version doesn't make sense. Go with the default
and let ethtool display the kernel version.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH net-next] net: usbnet: remove driver version

From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-10-10 22:51:47

On Fri, 9 Oct 2020 14:10:57 +0200 Heiner Kallweit wrote:
Obviously this driver version doesn't make sense. Go with the default
and let ethtool display the kernel version.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied, thank you!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help