Re: [PATCH] net/smscx5xx: change to of_get_mac_address() eth_platform_get_mac_address()
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2020-10-02 02:46:07
Also in:
linux-usb
Possibly related (same subject, not in this thread)
- 2020-10-02 · Re: [PATCH] net/smscx5xx: change to of_get_mac_address() eth_platform_get_mac_address() · David Miller <davem@davemloft.net>
- 2020-10-02 · Re: [PATCH] net/smscx5xx: change to of_get_mac_address() eth_platform_get_mac_address() · Lukasz Stelmach <l.stelmach@samsung.com>
On 10/1/2020 7:05 PM, David Miller wrote:
From: Łukasz Stelmach <l.stelmach@samsung.com> Date: Wed, 30 Sep 2020 16:25:25 +0200quoted
Use more generic eth_platform_get_mac_address() which can get a MAC address from other than DT platform specific sources too. Check if the obtained address is valid. Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>Failure to probe a MAC address should result in the selection of a random one. This way, the interface still comes up and is usable even when the MAC address fails to be probed.
True, however this behavior is not changed after this patch is applied, I would argue that this should be a separate patch. -- Florian