Re: [PATCHv2 iproute2-next 0/5] iproute2: add libbpf support

From
Hangbin Liu <hidden>
Date
2020-10-29 08:20:10
Also in
bpf
Reply to
David Ahern, 2020-10-29
On Wed, Oct 28, 2020 at 09:00:41PM -0600, David Ahern wrote:
quoted
quoted
quoted
You need to update libbpf to latest version.
nope. you need to be able to handle this. Ubuntu 20.10 was just
released, and it has a version of libbpf. If you are going to integrate
libbpf into other packages like iproute2, it needs to just work with
that version.
OK, I can replace bpf_program__section_name by bpf_program__title().
I believe this one can be handled through a compatability check. Looks
Do you mean add a check like

#ifdef has_section_name_support
	use bpf_program__section_name;
#else
	use bpf_program__title;
#endif
the rename / deprecation is fairly recent (78cdb58bdf15f from Sept 2020).
Yeah... As Andrii said, libbpf is in fast moving..
quoted
quoted
quoted
But this also remind me that I need to add bpf_program__section_name() to
configure checking. I will see if I missed other functions' checking.
This is going to be an on-going problem. iproute2 should work with
whatever version of libbpf is installed on that system.
I will make it works on Ubuntu 20.10, but with whatever version of libbpf?
That looks hard, especially with old libbpf.
I meant what comes with the OS. I believe I read that Fedora 33 was just
released as well. Does it have a version of libbpf? If so, please verify
it compiles and works with that version too. Before committing I will
also verify it compiles and links against a local version of libbpf (top
of tree) just to get a range of versions.
Yes, it makes sense. I will also check the libbpf on Fedora 33.

Thanks
Hangbin
Thread (167 messages) 167 messages, 15 authors, last reply 2020-12-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help