Re: [PATCH bpf-next V1 3/6] bpf: add BPF-helper for reading MTU from net_device via ifindex

From
Maciej Żenczykowski <hidden>
Date
2020-10-07 01:24:41
Also in
bpf
Reply to
Jakub Kicinski, 2020-10-07
On Tue, Oct 6, 2020 at 6:19 PM Jakub Kicinski [off-list ref] wrote:
On Tue, 6 Oct 2020 18:33:02 +0200 Jesper Dangaard Brouer wrote:
quoted
quoted
+static const struct bpf_func_proto bpf_xdp_mtu_lookup_proto = {
+   .func           = bpf_xdp_mtu_lookup,
+   .gpl_only       = true,
+   .ret_type       = RET_INTEGER,
+   .arg1_type      = ARG_PTR_TO_CTX,
+   .arg2_type      = ARG_ANYTHING,
+   .arg3_type      = ARG_ANYTHING,
+};
+
+
FWIW

CHECK: Please don't use multiple blank lines
#112: FILE: net/core/filter.c:5566:
FYI: It would be nice to have a similar function to return a device's
L2 header size (ie. 14 for ethernet) and/or hwtype.

Also, should this be restricted to gpl only?

[I'm not actually sure, I'm actually fed up with non-gpl code atm, and
wouldn't be against all bpf code needing to be gpl'ed...]
Thread (19 messages) 19 messages, 5 authors, last reply 2020-10-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help