On Mon, Oct 05, 2020 at 09:35:35AM +0100, Christoph Hellwig wrote:

Hi Dave,

please can you rever this?  This is the second xsk patch this year
that pokes into dma-mapping internals for absolutely not reason.

And we discussed this in detail the last time around: drivers have
absolutely no business poking into dma-direct.h and dma-noncoherent.h.
In fact because people do this crap I have a patch to remove these
headers that I'm about to queue up, so if this doesn't get reverted
the linux-next build will break soon.

Looks like it doesn't actually use any functionality and just
pointlessly includes internal headers.  So just removing dma-direct.h,
dma-noncoherent.h and swiotlb.h should do the job as well.

But guys, don't do this.