Thread (7 messages) 7 messages, 6 authors, 2020-10-27

Re: [PATCH] RDMA: Add rdma_connect_locked()

From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2020-10-27 12:01:01
Also in: linux-nvme, linux-rdma

On Tue, Oct 27, 2020 at 10:01:00AM +0800, Chao Leng wrote:
quoted
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index aad829a2b50d0f..f488dc5f4c2c61 100644
+++ b/drivers/nvme/host/rdma.c
@@ -1730,11 +1730,10 @@ static void nvme_rdma_process_nvme_rsp(struct nvme_rdma_queue *queue,
  	req->result = cqe->result;
  	if (wc->wc_flags & IB_WC_WITH_INVALIDATE) {
-		if (unlikely(!req->mr ||
-			     wc->ex.invalidate_rkey != req->mr->rkey)) {
+		if (unlikely(wc->ex.invalidate_rkey != req->mr->rkey)) {
  			dev_err(queue->ctrl->ctrl.device,
  				"Bogus remote invalidation for rkey %#x\n",
-				req->mr ? req->mr->rkey : 0);
+				req->mr->rkey);
Maybe the code version is incorrect, cause falsely code rollback.
Oh wow, thanks for noticing that, I made a git fumble when doing this
:(

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help