Re: [PATCH v4 3/3] mac80211: add KCOV remote annotations to incoming frame processing
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2020-10-28 21:54:44
Also in:
linux-wireless, lkml
Possibly related (same subject, not in this thread)
- 2020-10-29 · [PATCH v4 3/3] mac80211: add KCOV remote annotations to incoming frame processing · Aleksandr Nogikh <hidden>
On Wed, 2020-10-28 at 18:20 +0000, Aleksandr Nogikh wrote:
quoted hunk
From: Aleksandr Nogikh <redacted> Add KCOV remote annotations to ieee80211_iface_work and ieee80211_rx. This will enable coverage-guided fuzzing of mac80211 code that processes incoming 802.11 frames. Signed-off-by: Aleksandr Nogikh <redacted> --- v1 -> v2: * The commit now affects ieee80211_rx instead of ieee80211_tasklet_handler. --- include/net/mac80211.h | 2 ++ net/mac80211/iface.c | 2 ++ 2 files changed, 4 insertions(+)diff --git a/include/net/mac80211.h b/include/net/mac80211.h index e8e295dae744..f4c37a1b381e 100644 --- a/include/net/mac80211.h +++ b/include/net/mac80211.h@@ -4499,7 +4499,9 @@ void ieee80211_rx_napi(struct ieee80211_hw *hw, struct ieee80211_sta *sta, */ static inline void ieee80211_rx(struct ieee80211_hw *hw, struct sk_buff *skb) { + kcov_remote_start_common(skb_get_kcov_handle(skb)); ieee80211_rx_napi(hw, NULL, skb, NULL); + kcov_remote_stop(); }
Wouldn't it make more sense to push that a layer down into ieee80211_rx_napi(), or actually now perhaps even better ieee80211_rx_list(), so we get it even if the driver called that API in the first place? You might only care about hwsim at this point, but perhaps hwsim would get optimised .. johannes