On Tue, Oct 27, 2020 at 01:17:23PM +0100, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <redacted>
Use the helper that checks for overflows internally instead of manually
calculating the size of the new array.
Signed-off-by: Bartosz Golaszewski <redacted>
Acked-by: Daniel Vetter <redacted>
I don't expect conflicts with this going through some other tree, so
please make that happen. Or resend once I can apply this to drm trees.
Thanks, Daniel
quoted hunk ↗ jump to hunk
---
drivers/gpu/drm/drm_atomic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 58527f151984..09ad6a2ec17b 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -960,7 +960,8 @@ drm_atomic_get_connector_state(struct drm_atomic_state *state,
struct __drm_connnectors_state *c;
int alloc = max(index + 1, config->num_connector);
- c = krealloc(state->connectors, alloc * sizeof(*state->connectors), GFP_KERNEL);
+ c = krealloc_array(state->connectors, alloc,
+ sizeof(*state->connectors), GFP_KERNEL);
if (!c)
return ERR_PTR(-ENOMEM);
--
2.29.1
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch