Re: [PATCH net RFC] net: Clear IFF_TX_SKB_SHARING for all Ethernet devices using skb_padto

From
Jakub Kicinski <kuba@kernel.org>
Date
2020-10-22 15:22:44
Also in
lkml
Reply to
Xie He, 2020-10-22
On Thu, 22 Oct 2020 00:46:38 -0700 Xie He wrote:
It was very hard for me to attempt fixing. There are too many drivers
that need to be fixed. Fixing them is very time-consuming and may also
be error-prone. So I think it may be better to just remove
IFF_TX_SKB_SHARING from ether_setup. Drivers that support this feature
should add this flag by themselves. This also makes our code cleaner.
Are most of these drivers using skb_padto()? Is that the reason they
can't be sharing the SKB?

I think the IFF_TX_SKB_SHARING flag is only used by pktgen, so perhaps
we can make sure pktgen doesn't generate skbs < dev->min_mtu, and then
the drivers won't pad?
Thread (8 messages) 8 messages, 2 authors, last reply 2020-10-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help