Re: [PATCH v6 4/6] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support.
From: Pavel Machek <hidden>
Date: 2020-10-22 11:39:59
Also in:
linux-can, linux-devicetree, lkml
Hi!
quoted hunk ↗ jump to hunk
@@ -12,4 +12,13 @@ config CAN_CTUCANFD if CAN_CTUCANFD +config CAN_CTUCANFD_PCI + tristate "CTU CAN-FD IP core PCI/PCIe driver" + depends on PCI + help + This driver adds PCI/PCIe support for CTU CAN-FD IP core. + The project providing FPGA design for Intel EP4CGX15 based DB4CGX15 + PCIe board with PiKRON.com designed transceiver riser shield is available + at https://gitlab.fel.cvut.cz/canbus/pcie-ctu_can_fd . + endif
Ok, now the if in the first patch makes sense. It can stay. And it is separate module, so EXPORT_SYMBOLs make sense. Ok.
+#ifndef PCI_VENDOR_ID_TEDIA +#define PCI_VENDOR_ID_TEDIA 0x1760 +#endif
+#define PCI_DEVICE_ID_ALTERA_CTUCAN_TEST 0xCAFD +#define PCI_DEVICE_ID_TEDIA_CTUCAN_VER21 0xff00
These should go elsewhere.
+static bool use_msi = 1; +static bool pci_use_second = 1;
true? Best regards, Pavel -- http://www.livejournal.com/~pavelmachek
Attachments
- signature.asc [application/pgp-signature] 195 bytes