Re: [PATCH v2 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip
From: Pali Rohár <pali@kernel.org>
Date: 2020-10-21 22:30:27
Also in:
linux-devicetree, linux-mmc, linux-wireless, lkml
On Tuesday 20 October 2020 14:57:54 Jerome Pouiller wrote:
From: Jérôme Pouiller <jerome.pouiller@silabs.com> Add Silabs SDIO ID to sdio_ids.h. Note that the values used by Silabs are uncommon. A driver cannot fully rely on the SDIO PnP. It should also check if the device is declared in the DT. Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Looks good! Acked-by: Pali Rohár <pali@kernel.org>
quoted hunk ↗ jump to hunk
--- include/linux/mmc/sdio_ids.h | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h index 12036619346c..20a48162f7fc 100644 --- a/include/linux/mmc/sdio_ids.h +++ b/include/linux/mmc/sdio_ids.h@@ -25,6 +25,11 @@ * Vendors and devices. Sort key: vendor first, device next. */ +// Silabs does not use a reliable vendor ID. To avoid conflicts, the driver +// won't probe the device if it is not also declared in the DT. +#define SDIO_VENDOR_ID_SILABS 0x0000 +#define SDIO_DEVICE_ID_SILABS_WF200 0x1000 + #define SDIO_VENDOR_ID_STE 0x0020 #define SDIO_DEVICE_ID_STE_CW1200 0x2280-- 2.28.0