Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-10-14 23:27:00
Also in:
bridge, lkml
On Mon, 12 Oct 2020 14:04:24 +0000 Henrik Bjoernlund wrote:
quoted hunk ↗ jump to hunk
+ /* This CCM related status is based on the latest received CCM PDU. */ + u8 port_tlv_value; /* Port Status TLV value */ + u8 if_tlv_value; /* Interface Status TLV value */ + + /* CCM has not been received for 3.25 intervals */ + bool ccm_defect; + + /* (RDI == 1) for last received CCM PDU */ + bool rdi; + + /* Indications that a CCM PDU has been seen. */ + bool seen; /* CCM PDU received */ + bool tlv_seen; /* CCM PDU with TLV received */ + /* CCM PDU with unexpected sequence number received */ + bool seq_unexp_seen;
Please consider using a u8 bitfield rather than a bunch of bools,
if any of this structures are expected to have many instances.
That'd save space.