Re: [PATCH] ptp: ptp_clockmatrix: initialize variables

On 10/12/20 3:01 PM, Richard Cochran wrote:

On Sun, Oct 11, 2020 at 01:09:55PM -0700, trix@redhat.com wrote:

quoted

From: Tom Rix <trix@redhat.com>

Clang static analysis reports this representative problem

ptp_clockmatrix.c:1852:2: warning: 5th function call argument
  is an uninitialized value
        snprintf(idtcm->version, sizeof(idtcm->version), "%u.%u.%u",
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

idtcm_display_version_info() calls several idtcm_read_*'s without
checking a return status.

So why not check the return status?

calling function is a print information only function that returns void.

I do think not adding error handling is worth it.

I could change the return and then the calls if if you like.

Tom

Your patch papers over the issue.

Thanks,
Richard