Thread (5 messages) 5 messages, 2 authors, 2020-10-12

Re: [PATCH 1/2] cx82310_eth: re-enable ethernet mode after router reboot

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-10-12 16:50:46
Also in: linux-usb, lkml

On Mon, 12 Oct 2020 12:42:55 +0200 Ondrej Zary wrote:
On Monday 12 October 2020, Jakub Kicinski wrote:
quoted
On Sat, 10 Oct 2020 16:00:46 +0200 Ondrej Zary wrote:  
quoted
When the router is rebooted without a power cycle, the USB device
remains connected but its configuration is reset. This results in
a non-working ethernet connection with messages like this in syslog:
	usb 2-2: RX packet too long: 65535 B

Re-enable ethernet mode when receiving a packet with invalid size of
0xffff.  
Patch looks good, but could you explain what's a reboot without a power
cycle in this case? The modem gets reset but USB subsystem doesn't know
it and doesn't go though a unbind() + bind() cycle?  
The router can be rebooted through the web interface. The reboot does not 
disconnect the USB device - it remains connected as if nothing happened. Only 
wrong data starts to come in.
I see. Applied to net-next, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help