Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter
flat view
From: Dan Carpenter <hidden>
Date: 2020-10-08 13:42:01
Also in:
lkml
On Thu, Oct 08, 2020 at 07:58:04PM +0800, Coiby Xu wrote:
quoted hunk ↗ jump to hunk
-static int -qlge_reporter_coredump(struct devlink_health_reporter *reporter, - struct devlink_fmsg *fmsg, void *priv_ctx, - struct netlink_ext_ack *extack) +static int fill_seg_(struct devlink_fmsg *fmsg, + struct mpi_coredump_segment_header *seg_header, + u32 *reg_data) { - return 0; + int i; + int header_size = sizeof(struct mpi_coredump_segment_header);
Please use the sizeof() directly in the code. Don't introduce indirection if you can help it.
quoted hunk ↗ jump to hunk
+ int regs_num = (seg_header->seg_size - header_size) / sizeof(u32); + int err; +
regards, dan carpenter