Re: [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers

From
David Miller <davem@davemloft.net>
Date
2020-10-02 22:28:33
Also in
ceph-devel, linux-block, linux-nvme, linux-scsi, lkml
Reply to
Coly Li, 2020-10-02
From: Coly Li <redacted>
Date: Fri,  2 Oct 2020 16:27:27 +0800
As Sagi Grimberg suggested, the original fix is refind to a more common
inline routine:
    static inline bool sendpage_ok(struct page *page)
    {
        return  (!PageSlab(page) && page_count(page) >= 1);
    }
If sendpage_ok() returns true, the checking page can be handled by the
concrete zero-copy sendpage method in network layer.
Series applied.
The v10 series has 7 patches, fixes a WARN_ONCE() usage from v9 series,
 ...

I still haven't heard from you how such a fundamental build failure
was even possible.

If the v9 patch series did not even compile, how in the world did you
perform functional testing of these changes?

Please explain this to me, instead of just quietly fixing it and
posting an updated series.

Thank you.
Thread (11 messages) 11 messages, 2 authors, last reply 2020-10-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help