Re: [PATCH net] ip6_tunnel: set inner ipproto before ip6_tnl_encap.
From: Vadim Fedorenko <hidden>
Date: 2020-10-31 01:57:39
On 30.10.2020 12:54, Alexander Ovechkin wrote:
On 30 Oct 2020, at 14:01, Vadim Fedorenko [off-list ref] wrote:quoted
Could not reproduce the bug. Could you please provide a test scenario?It can be reproduced if your net device doesn’t support udp tunnel segmentation (i.e its features do not have SKB_GSO_UDP_TUNNEL). If you try to send packet larger than the MTU fou6-only tunnel (without any other encap) it will be dropped, because of invalid skb->inner_ipproto (that will be equal to IPPROTO_UDP — outer protocol, instead of IPPROTO_IPV6). skb->inner_ipproto is used here: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/tree/net/ipv4/udp_offload.c?id=07e0887302450a62f51dba72df6afb5fabb23d1c#n168
Ok, all my tests show that MPLS encap is working after this moving, so I have no concerns too.