Re: [PATCH v4 2/3] Modify return value of nla_strlcpy to match that of strscpy.
From: Kees Cook <hidden>
Date: 2020-10-30 19:26:34
Also in:
linux-hardening
On Fri, Oct 30, 2020 at 04:36:46PM +0100, laniel_francis@privacyrequired.com wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index 2a76a2f5ed88..f9b053b30a7b 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c@@ -1170,7 +1170,7 @@ static struct Qdisc *qdisc_create(struct net_device *dev, #ifdef CONFIG_MODULES if (ops == NULL && kind != NULL) { char name[IFNAMSIZ]; - if (nla_strlcpy(name, kind, IFNAMSIZ) < IFNAMSIZ) { + if (nla_strlcpy(name, kind, IFNAMSIZ) > 0) { /* We dropped the RTNL semaphore in order to * perform the module load. So, even if we * succeeded in loading the module we have to
Oops, I think this should be >= 0 ? -- Kees Cook