Thread (24 messages) 24 messages, 4 authors, 2020-10-22

Re: [PATCH iproute2-next 11/15] lib: Extract from iplink_vlan a helper to parse key:value arrays

From: Roman Mashak <hidden>
Date: 2020-10-20 11:33:39

Petr Machata [off-list ref] writes:


[...]
+static int parse_qos_mapping(__u32 key, char *value, void *data)
+{
+	struct nlmsghdr *n = data;
+	struct ifla_vlan_qos_mapping m = {
+		.from = key,
+	};
+
+	if (get_u32(&m.to, value, 0))
+		return 1;
+
+	addattr_l(n, 1024, IFLA_VLAN_QOS_MAPPING, &m, sizeof(m));
+	return 0;
+}
addatr_l() may fail if netlink buffer size is not sufficient, may be:

return addattr_l(...);

would be better.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help