Re: realtek PHY commit bbc4d71d63549 causes regression

Hi Ard,

[...]

quoted

quoted

quoted

You can also use '' as the phy-mode, which results in
PHY_INTERFACE_MODE_NA, which effectively means, don't touch the PHY
mode, something else has already set it up. This might actually be the
correct way to go for ACPI. In the DT world, we tend to assume the
bootloader has done the absolute minimum and Linux should configure
everything. The ACPI takes the opposite view, the firmware will do the
basic hardware configuration, and Linux should not touch it, or ask
ACPI to modify it.

Indeed, the firmware should have set this up.

Would EDK2 take care of the RGMII Rx/Tx delays even when configured to
use a DT instead of ACPI?

Yes. The network driver has no awareness whatsoever which h/w
description is being provided to the OS.

quoted

quoted

This would mean we could > do this in the driver: it currently uses

priv->phy_interface = device_get_phy_mode(&pdev->dev);

Can we just assign that to PHY_INTERFACE_MODE_NA instead?

I have tried this, and it seems to fix the issue. I will send out a
patch against the netsec driver.

Great thanks!

Cheers
/Ilias