Thread (23 messages) 23 messages, 4 authors, 2020-10-26

Re: [PATCH iproute2-next v3 2/2] tc: implement support for terse dump

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: 2020-10-17 11:24:03

On 2020-10-16 12:42 p.m., Vlad Buslov wrote:
All action print callbacks have arg==NULL check and return at the
beginning. To print action type we need either to have dedicated
'brief_dump' callback instead of reusing print_aop() or extend/refactor
print_aop() implementation for all actions to always print the type
before checking the arg. What do you suggest?
Either one sounds appealing - the refactoring feels simpler
as opposed to a->terse_print().

BTW: the action index, unless i missed something, is not transported
from the kernel for terse option. It is an important parameter
when actions are shared by filters (since they will have the same
index).
Am i missing something?

cheers,
jamal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help