Re: [PATCH 3/5] netlink: rework policy dump to support multiple policies

On Fri, 02 Oct 2020 22:13:36 +0200 Johannes Berg wrote:

quoted

quoted

+int netlink_policy_dump_add_policy(struct netlink_policy_dump_state **pstate,
+				   const struct nla_policy *policy,
+				   unsigned int maxtype);  

Personal preference perhaps, but I prefer kdoc with the definition.  

I realized recently that this is actually better, because then "make
W=1" will in fact check the kernel-doc for consistency ... but it
doesn't do it in header files.

Just have to get into the habit now ...

:o 

I was wondering why I didn't see errors from headers in the past!

I guess it's because of the volume of messages this would cause.