Re: [PATCH net 08/12] ipv6: advertise IFLA_LINK_NETNSID when dumping ipv6 addresses
From: Nicolas Dichtel <hidden>
Date: 2020-10-01 15:58:49
Le 01/10/2020 à 09:59, Sabrina Dubroca a écrit :
Currently, we're not advertising link-netnsid when dumping IPv6
addresses, so the "ip -6 addr" command will not correctly interpret
the value of the IFLA_LINK attribute.
For example, we'll get:
9: macvlan0@macvlan0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 state UP qlen 1000
<snip>
Instead of:
9: macvlan0@if9: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 state UP qlen 1000 link-netns main
<snip>
ndisc_ifinfo_sysctl_change calls inet6_fill_ifinfo without rcu or
rtnl, so I'm adding rcu_read_lock around rtnl_fill_link_netnsid.I don't think this is needed. ndisc_ifinfo_sysctl_change() takes a reference on the idev (with in6_dev_get(dev)).