Re: [RFC net-next 7/9] genetlink: bring back per op policy

From
Johannes Berg <johannes@sipsolutions.net>
Date
2020-10-01 07:53:28
Reply to
Jakub Kicinski, 2020-10-01
On Wed, 2020-09-30 at 17:05 -0700, Jakub Kicinski wrote:
Add policy to the struct genl_ops structure, this time
with maxattr, so it can be used properly.

Propagate .policy and .maxattr from the family
in genl_get_cmd() if needed, this say the rest of the
typo: "this way"
code does not have to worry if the policy is per op
or global.
Maybe make 'taskstats', which I munged a bit in commit 3b0f31f2b8c9
("genetlink: make policy common to family") go back to using per-command 
policy - properly this time with maxattr?


But the code here looks good to me.

Reviewed-by: Johannes Berg <johannes@sipsolutions.net>

johannes
Thread (24 messages) 24 messages, 3 authors, last reply 2020-10-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help