Re: [net-next PATCH v7 1/6] Documentation: ACPI: DSD: Document MDIO PHY
From: Calvin Johnson <hidden>
Date: 2020-09-29 05:18:10
Also in:
linux-acpi
From: Calvin Johnson <hidden>
Date: 2020-09-29 05:18:10
Also in:
linux-acpi
Hi Grant, On Fri, Sep 25, 2020 at 02:34:21PM +0100, Grant Likely wrote:
quoted
+DSDT entry for MDIO node +------------------------ +a) Silicon Component +-------------------- + Scope(_SB) + { + Device(MDI0) { + Name(_HID, "NXP0006") + Name(_CCA, 1) + Name(_UID, 0) + Name(_CRS, ResourceTemplate() { + Memory32Fixed(ReadWrite, MDI0_BASE, MDI_LEN) + Interrupt(ResourceConsumer, Level, ActiveHigh, Shared) + { + MDI0_IT + } + }) // end of _CRS for MDI0 + Name (_DSD, Package () { + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () {"little-endian", 1}, + }Adopting the 'little-endian' property here makes little sense. This looks like legacy from old PowerPC DT platforms that doesn't belong here. I would drop this bit.
I'm unable to drop this as the xgmac_mdio driver relies on this variable to change the io access to little-endian. Default is big-endian. Please see: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/freescale/xgmac_mdio.c?h=v5.9-rc7#n55 Thanks Calvin