RE: [PATCH bpf-next 3/3] selftests/bpf: add raw_tp_test_run
From: John Fastabend <john.fastabend@gmail.com>
Date: 2020-09-23 04:49:21
Also in:
bpf
Song Liu wrote:
This test runs test_run for raw_tracepoint program. The test covers ctx input, retval output, and proper handling of cpu_plus field. Signed-off-by: Song Liu <redacted> ---
[...]
+
+ test_attr.ctx_size_in = sizeof(args);
+ err = bpf_prog_test_run_xattr(&test_attr);
+ CHECK(err < 0, "test_run", "err %d\n", errno);
+ CHECK(test_attr.retval != expected_retval, "check_retval",
+ "expect 0x%x, got 0x%x\n", expected_retval, test_attr.retval);
+
+ for (i = 0; i < nr_online; i++)
+ if (online[i]) {
+ DECLARE_LIBBPF_OPTS(bpf_prog_test_run_opts, opts,
+ .cpu_plus = i + 1,
+ );
+ err = bpf_prog_test_run_xattr_opts(&test_attr, &opts);
+ CHECK(err < 0, "test_run_with_opts", "err %d\n", errno);
+ CHECK(skel->data->on_cpu != i, "check_on_cpu",
+ "got wrong value\n");Should we also check retval here just to be thorough? Thanks, John
quoted hunk ↗ jump to hunk
+ } +cleanup: + close(comm_fd); + test_raw_tp_test_run__destroy(skel); + free(online); +}diff --git a/tools/testing/selftests/bpf/progs/test_raw_tp_test_run.c b/tools/testing/selftests/bpf/progs/test_raw_tp_test_run.c