Thread (2 messages) flat view 2 messages, 2 authors, 2020-09-02

Re: [PATCH bpf-next] xsk: fix possible segfault in xsk umem diagnostics

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2020-09-02 14:58:25
Also in: bpf

On 9/2/20 10:52 AM, Magnus Karlsson wrote:
Fix possible segfault in the xsk diagnostics code when dumping
information about the umem. This can happen when a umem has been
created, but the socket has not been bound yet. In this case, the xsk
buffer pool does not exist yet and we cannot dump the information
that was moved from the umem to the buffer pool. Fix this by testing
for the existence of the buffer pool and if not there, do not dump any
of that information.

Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Reported-by: syzbot+3f04d36b7336f7868066@syzkaller.appspotmail.com
Fixes: c2d3d6a47462 ("xsk: Move queue_id, dev and need_wakeup to buffer pool")
Fixes: 7361f9c3d719 ("xsk: Move fill and completion rings to buffer pool")
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help