On 9/1/20 5:41 PM, Andrii Nakryiko wrote:

On Thu, Aug 27, 2020 at 10:38 PM Yonghong Song [off-list ref] wrote:

quoted

Modified existing bpf_iter_test_file.c program to check whether
all accessed files from the main thread or not.

Modified existing bpf_iter_test_file program to check
whether all accessed files from the main thread or not.
   $ ./test_progs -n 4
   ...
   #4/7 task_file:OK
   ...
   #4 bpf_iter:OK
   Summary: 1/24 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Yonghong Song <redacted>
---

Acked-by: Andrii Nakryiko <redacted>

quoted

  .../selftests/bpf/prog_tests/bpf_iter.c       | 21 +++++++++++++++++++
  .../selftests/bpf/progs/bpf_iter_task_file.c  | 10 ++++++++-
  2 files changed, 30 insertions(+), 1 deletion(-)

[...]

quoted

+       if (CHECK(pthread_join(thread_id, &ret) || ret != NULL,
+                 "pthread_join", "pthread_join failed\n"))
+               goto done;
+
+       CHECK(skel->bss->count != 0, "",

nit: please use non-empty string for second argument

Okay, will change to "check_count" instead of empty string. Thanks!

quoted

+             "invalid non pthread file visit %d\n", skel->bss->count);
+
+done:
         bpf_iter_task_file__destroy(skel);
  }

[...]