Thread (44 messages) 44 messages, 7 authors, 2020-09-30

Re: [patch V2 21/36] net: usb: kaweth: Replace kaweth_control() with usb_control_msg()

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2020-09-30 06:22:57
Also in: intel-wired-lan, linux-doc, linux-usb, linux-wireless, lkml

On Tue, Sep 29, 2020 at 10:25:30PM +0200, Thomas Gleixner wrote:
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

kaweth_control() is almost the same as usb_control_msg() except for the
memory allocation mode (GFP_ATOMIC vs GFP_NOIO) and the in_interrupt()
check.

All the invocations of kaweth_control() are within the probe function in
fully preemtible context so there is no reason to use atomic allocations,
GFP_NOIO which is used by usb_control_msg() is perfectly fine.

Replace kaweth_control() invocations from probe with usb_control_msg().

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <redacted>
Note, the usb_control_msg_send/recv() new functions that will show up in
5.10-rc1 will help a bit with this logic, but for what you have now,
this is fine, nice cleanups.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help