Thread (20 messages) 20 messages, 6 authors, 2020-09-25

Re: [RFC PATCH] bonding: linkdesc can be static

flat view

From: Jarod Wilson <hidden>
Date: 2020-09-23 11:29:59
Also in: lkml, oe-kbuild-all

On Wed, Sep 23, 2020 at 12:15 AM kernel test robot [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: kernel test robot <redacted>
---
 bond_procfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c
index 91ece68607b23..9b1b37a682728 100644
--- a/drivers/net/bonding/bond_procfs.c
+++ b/drivers/net/bonding/bond_procfs.c
@@ -8,7 +8,7 @@
 #include "bonding_priv.h"

 #ifdef CONFIG_BONDING_LEGACY_INTERFACES
-const char *linkdesc = "Slave";
+static const char *linkdesc = "Slave";
 #else
 const char *linkdesc = "Link";
 #endif
Good attempt, robot, but you missed the #else. Will fold a full
version into my set.

-- 
Jarod Wilson
jarod@redhat.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help