Re: [PATCH 08/14] xprtrdma: drop double zeroing
From: Chuck Lever <chuck.lever@oracle.com>
Date: 2020-09-20 15:38:29
Also in:
kernel-janitors, linux-nfs, lkml
Thanks, Julia!
On Sep 20, 2020, at 7:26 AM, Julia Lawall [off-list ref] wrote: sg_init_table zeroes its first argument, so the allocation of that argument doesn't have to. the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,n,flags; @@ x = - kcalloc + kmalloc_array (n,sizeof(*x),flags) ... sg_init_table(x,n) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Acked-by: Chuck Lever <chuck.lever@oracle.com> This one goes to Anna.
quoted hunk ↗ jump to hunk
--- net/sunrpc/xprtrdma/frwr_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_ops.c--- a/net/sunrpc/xprtrdma/frwr_ops.c +++ b/net/sunrpc/xprtrdma/frwr_ops.c@@ -124,7 +124,7 @@ int frwr_mr_init(struct rpcrdma_xprt *r_if (IS_ERR(frmr)) goto out_mr_err; - sg = kcalloc(depth, sizeof(*sg), GFP_NOFS); + sg = kmalloc_array(depth, sizeof(*sg), GFP_NOFS); if (!sg) goto out_list_err;
-- Chuck Lever