Re: [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

From
Henrik Bjoernlund <hidden>
Date
2020-09-15 08:54:40
Also in
bridge, lkml
Reply to
Jakub Kicinski, 2020-09-04
Thanks for the review. Comments below.

The 09/04/2020 08:02, Jakub Kicinski wrote:
On Fri, 4 Sep 2020 09:15:24 +0000 Henrik Bjoernlund wrote:
quoted
+     rcu_read_lock();
+     b_port = rcu_dereference(mep->b_port);
+     if (!b_port)
+             return NULL;
+     skb = dev_alloc_skb(CFM_CCM_MAX_FRAME_LENGTH);
+     if (!skb)
+             return NULL;
net/bridge/br_cfm.c:171:23: warning: context imbalance in 'ccm_frame_build' - different lock contexts for basic block
I will assure that rcu_read_unlock() is called before any return.

-- 
/Henrik
Thread (29 messages) 29 messages, 6 authors, 2020-09-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help