Thread (7 messages) 7 messages, 4 authors, 2020-09-14

Re: [Linux-kernel-mentees] [PATCH net] tipc: Fix memory leak in tipc_group_create_member()

From: Peilin Ye <hidden>
Date: 2020-09-13 07:49:40
Also in: linux-kernel-mentees, lkml

On Sat, Sep 12, 2020 at 06:23:36PM -0700, David Miller wrote:
From: Peilin Ye <redacted>
Date: Sat, 12 Sep 2020 06:22:30 -0400
quoted
@@ -291,10 +291,11 @@ static void tipc_group_add_to_tree(struct tipc_group *grp,
 		else if (key > nkey)
 			n = &(*n)->rb_right;
 		else
-			return;
+			return -1;
Use a real error code like "-EEXIST", thank you.
Ah, I'll fix it in v2 soon, sorry about that. I saw another function in
this file returning -1.

Peilin Ye
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help