Re: [PATCH 01/32] wireless: marvell: mwifiex: sdio: Move 'static const struct's into their own header file
From: Kalle Valo <hidden>
Date: 2020-09-01 09:15:45
Also in:
linux-wireless, lkml
Lee Jones [off-list ref] wrote:
Only include these tables in the 1 source file they are used.
Fixes hundreds of W=1 warnings!
Fixes the following W=1 kernel build warning(s):
In file included from drivers/net/wireless/marvell/mwifiex/main.h:59,
from drivers/net/wireless/marvell/mwifiex/main.c:22:
drivers/net/wireless/marvell/mwifiex/sdio.h:705:41: warning: ‘mwifiex_sdio_sd8801’ defined but not used [-Wunused-const-variable=]
705 | static const struct mwifiex_sdio_device mwifiex_sdio_sd8801 = {
| ^~~~~~~~~~~~~~~~~~~
NB: There were 100's of these - snipped for brevity.
Cc: Amitkumar Karwar <redacted>
Cc: Ganapathi Bhat <redacted>
Cc: Xinming Hu <redacted>
Cc: Kalle Valo <redacted>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <redacted>I don't think static const variables should be in a .h file. Wouldn't sdio.c be the right place for these? At least from a quick look I got that impression. Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/11728301/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches